Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alipay):支付宝小程序在showModal属性showCancel且没有cancelText真机调试按钮显示undefined #7590

Merged
merged 4 commits into from
Sep 24, 2020
Merged

fix(alipay):支付宝小程序在showModal属性showCancel且没有cancelText真机调试按钮显示undefined #7590

merged 4 commits into from
Sep 24, 2020

Conversation

fred8617
Copy link
Contributor

@fred8617 fred8617 commented Sep 11, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
修复支付宝小程序在showModal属性showCancel为false,并且未设置cancelText时文字在真机中显示为undefined

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id Taro.showModal 使用时 cancelText 未定义 #5720
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@fred8617
bugfix
a28d95c 
修复支付宝小程序在showModal属性showCancel为false时文字在真机中显示为undefined
@fred8617 fred8617 changed the title fix(alipay) fix(alipay):支付宝小程序在showModal属性showCancel且没有cancelText真机调试按钮显示undefined Sep 11, 2020
@fred8617
Copy link
Contributor Author

@Chen-jj

@taro-bot2 taro-bot2 bot mentioned this pull request Sep 12, 2020
Closed
@taro-bot2 taro-bot2 bot mentioned this pull request Sep 19, 2020
Closed
@Chen-jj Chen-jj added the V-3 Version - 3.x label Sep 24, 2020
@Chen-jj Chen-jj merged commit 91ede02 into NervJS:next Sep 24, 2020
Chen-jj added a commit that referenced this pull request Sep 24, 2020
@Chen-jj
fix(platform): 同步 3.0 修改
4ead1d8 
* #7590
* fix(size): 尺寸计算错误
@taro-bot2 taro-bot2 bot mentioned this pull request Sep 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chen-jj Chen-jj Chen-jj approved these changes

Assignees
No one assigned
Labels
V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fred8617 @Chen-jj